Read failed test logs from file#1133
Merged
Merged
Conversation
toinehartman
force-pushed
the
fix/failed-test-logs-from-file
branch
from
78646a9 to
6e1eeb6
Compare
Member
Author
|
Note that, before merging this PR, 622cea0 should be reverted. This only serves to demonstrate how this works. |
toinehartman
force-pushed
the
fix/failed-test-logs-from-file
branch
from
6e1eeb6 to
49528ab
Compare
toinehartman
changed the title
DavyLandman
approved these changes
Jun 26, 2026
DavyLandman
left a comment
DavyLandman
left a comment
Member
There was a problem hiding this comment.
Nice, no more UI interactions that can fail 👍🏼
This reverts commit 622cea0.
toinehartman
force-pushed
the
fix/failed-test-logs-from-file
branch
from
db4093e to
570d288
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we located the VS Code logs in #1075, we can also use them for the log snippets in the output of failed tests.
This PR attempts to read the logs from disk first, and only falls back to zooming/copying the output window if no logs can be found on disk. This should decrease the number of UI interactions and increase reliability of reporting on failed tests.